feat(ci): add a playwright-1.63.0 tag #1
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "feat/playwright-1.63"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Adds
forge.cloud.adibilis.ch/platform/ci-images:playwright-1.63.0, the image core/core's e2e shards need for the@playwright/test1.58.2 → 1.63.0 bump. Per this repo's pinning rule the image must exist before the consumer points at it, so this merges first; the consumer bump then lands in one commit (lockfile +container:).Both playwright tags are built for the length of the upgrade. Until core/core's bump merges its shards still pull 1.58.2, and a shard whose image and lockfile disagree downloads a second browser set at runtime — exactly what pre-baking avoids. Once nothing references 1.58.2, drop that matrix entry; the published tag stays in the registry either way, it just stops being rebuilt.
The version is a
PLAYWRIGHT_VERSIONbuild arg, not a second copy of the Dockerfile, so two coexisting tags can't drift.The playwright smoke test now asserts the baked version — it never did before. It checked only
docker --versionandcurl --version, so a base-image bump that moved the Playwright version would have published silently under a tag promising the old one. It now greps the base image's own/ms-playwright/.docker-info:npx playwright --versionis unusable here: with nothing installed locally, npx downloads that version from npm and then reports what it just fetched, so it passes for whatever the image actually contains. I hit that while writing this and switched.Verified locally (arm64, so the docker CLI layer differs from the runner's x86_64):
--build-arg PLAYWRIGHT_VERSION=1.63.0builds;docker --version(29.8.1),curl --versionand the version assertion all pass.1.58.2correctly fails on that image.--build-arg PLAYWRIGHT_VERSION=1.58.2still builds and passes its own assertion, so the existing tag is unaffected.Publishing needs no new secret — the workflow's existing
REGISTRY_TOKENcovers both tags. It runs on push tomaintouching a*.Dockerfileor the workflow, which this PR does.